Skip to content

Comments

Add filesystem loading for frameworks and clarify starter definitions#9

Merged
davidahmann merged 1 commit intomainfrom
codex/framework-fs-load-starter-labels
Feb 19, 2026
Merged

Add filesystem loading for frameworks and clarify starter definitions#9
davidahmann merged 1 commit intomainfrom
codex/framework-fs-load-starter-labels

Conversation

@davidahmann
Copy link
Contributor

@davidahmann davidahmann commented Feb 19, 2026

Summary

  • add runtime filesystem loading for framework YAML via framework.Load/proof.LoadFramework(path) while preserving built-in embedded framework IDs
  • update proof frameworks show help text to support id-or-path and add a human summary line to proof frameworks list
  • align framework positioning/docs as built-in starter definitions and remove overclaims in README
  • add tests for filesystem framework loading in core/API/CLI paths

Validation

  • go test ./...
  • go vet ./...

@davidahmann davidahmann merged commit 7ec1233 into main Feb 19, 2026
8 checks passed
@davidahmann davidahmann deleted the codex/framework-fs-load-starter-labels branch February 19, 2026 01:01
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa61668d4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}

func Load(idOrFile string) (*Framework, error) {
if info, err := os.Stat(idOrFile); err == nil {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve embedded lookup before filesystem probing

Checking os.Stat(idOrFile) before embedded resolution makes built-in framework IDs/file names depend on the caller’s current working directory: any local file named like a built-in (for example eu-ai-act.yaml) will be loaded instead of the embedded starter definition. This is a regression introduced here because List() calls Load() with embedded file names, so proof frameworks list can silently show user-local data or fail if that local file is invalid, breaking deterministic built-in behavior.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant